[codex] Use assert in Docker build test#3176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the explicit
raise AssertionError(full_log) from excin the Docker build test with anassertthat still reports the full build log.This keeps the unsupported Windows container skip behavior while making the assertion style simpler.
Checks
Pre-commit and pre-push hooks passed, including Ruff, mypy, pyright, ty, and pyrefly.
Also ran the Docker test under coverage successfully; the scoped coverage report for this single file remains 93% because the
BuildErrorhandler is not exercised on macOS after removing the pragma.Note
Low Risk
Low risk: only adjusts test failure/skip logic in the Docker build test, without changing runtime code paths.
Overview
Simplifies the Docker image build failure handling in
tests/mock_vws/test_docker.pyby replacing a manualraise AssertionError(...)with anassertthat includes the full build log.The test still skips when the
BuildErrormatches known Windows-container manifest errors, but now fails with a standard assertion (and clearer log output) for unexpected build failures.Reviewed by Cursor Bugbot for commit 126d152. Bugbot is set up for automated code reviews on this repo. Configure here.